bazel/wasm: Migrate cargo dependencies to crate_universe#45787
Open
leonm1 wants to merge 2 commits into
Open
Conversation
cargo-raze is deprecated, with crate_universe suggested as the migration path: https://github.com/google/cargo-raze. Signed-off-by: Matt Leon <mattleon@google.com>
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
@phlax for visibility |
Signed-off-by: Matt Leon <mattleon@google.com>
Contributor
|
The change looks fine to me. @agrawroh or @mathetake does this affect Rust dynamic modules in any way? /wait-any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: bazel/wasm: Migrate cargo dependencies to crate_universe
Additional Description:
cargo-raze is deprecated, with crate_universe suggested as the migration path: https://github.com/google/cargo-raze.
Risk Level: None / test-only.
Testing: Unit tested with
bazel test //test/extensions/common/wasm/... //test/extensions/filters/http/wasm/... //test/extensions/filters/network/wasm/...(and with--define wasm=wasmtime).Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]